hare

commit 2adeb130542f0a75c72c9c75c3e06579c23b6b11
parent 1f36f212bc7edf34eeade0b25ab37cffcf5331f2
Author: Byron Torres <b@torresjrjr.com>
Date:   Thu,  4 Apr 2024 22:34:42 +0100

time::chrono: lookupzone: use sort

Diffstat:
M
time/chrono/timezone.ha
 | 
38
++++++++++++++++----------------------

1 file changed, 16 insertions(+), 22 deletions(-)
diff --git a/time/chrono/timezone.ha b/time/chrono/timezone.ha
@@ -5,6 +5,7 @@ use bufio;
 use io;
 use os;
 use path;
+use sort;
 use strings;
 use time;
 
@@ -120,44 +121,37 @@ fn lookupzone(loc: locality, inst: time::instant) *zone = {
 		return &loc.zones[0];
 	};
 
-	if (
-		len(loc.transitions) == 0
-		|| time::compare(inst, loc.transitions[0].when) == -1
-	) {
+	let trs = loc.transitions[..];
+
+	if (len(trs) == 0 || time::compare(inst, trs[0].when) == -1) {
 		// TODO: special case
 		abort("lookupzone(): time is before known transitions");
 	};
 
-	let lo = 0z;
-	let hi = len(loc.transitions);
-	for (hi - lo > 1) {
-		const mid = lo + (hi - lo) / 2;
-		const middle = loc.transitions[mid].when;
-		switch (time::compare(inst, middle)) {
-		case -1 =>
-			hi = mid;
-		case 0 =>
-			lo = mid; break;
-		case 1 =>
-			lo = mid;
-		case =>
-			abort("Unreachable");
-		};
-	};
+	// index of transition which inst is equal to or greater than.
+	const idx = -1 + sort::rbisect(
+		trs, size(transition), &inst, &cmpinstants,
+	);
 
-	const z = &loc.zones[loc.transitions[lo].zoneindex];
+	const z = &loc.zones[trs[idx].zoneindex];
 
 	// if we've reached the end of the locality's transitions, try its
 	// posix_extend string
 	//
 	// TODO: Unfinished; complete.
-	if (lo == len(loc.transitions) - 1 && loc.posix_extend != "") {
+	if (idx == len(trs) - 1 && loc.posix_extend != "") {
 		void;
 	};
 
 	return z;
 };
 
+fn cmpinstants(a: const *opaque, b: const *opaque) int = {
+	let a = a: *transition;
+	let b = b: *time::instant;
+	return time::compare(a.when, *b): int;
+};
+
 // Creates a [[timezone]] with a single [[zone]]. Useful for fixed offsets.
 // For example, replicate the civil time Hawaii timezone on Earth:
 //