harec

commit 17e06988a8edf1437010971c5cb5c89bb10d82b9
parent 5183bef8871de73e9d74bdc15cd3960e6b96814e
Author: Drew DeVault <sir@cmpwn.com>
Date:   Thu, 24 Dec 2020 09:36:35 -0500

gen: implement indirect assignment

Diffstat:
M
src/check.c
 | 
2
+-
M
src/gen.c
 | 
27
++++++++++++++++++---------

2 files changed, 19 insertions(+), 10 deletions(-)
diff --git a/src/check.c b/src/check.c
@@ -68,7 +68,7 @@ check_expr_assign(struct context *ctx,
 	check_expression(ctx, aexpr->assign.value, value);
 
 	expr->assign.object = object;
-	expr->assign.object = value;
+	expr->assign.value = value;
 
 	if (aexpr->assign.indirect) {
 		expect(object->result->storage == TYPE_STORAGE_POINTER,
diff --git a/src/gen.c b/src/gen.c
@@ -170,19 +170,28 @@ gen_assign(struct gen_context *ctx,
 	const struct qbe_value *out)
 {
 	assert(out == NULL); // Invariant
-	assert(!expr->assign.indirect); // TODO
 
 	const struct expression *object = expr->assign.object;
 	const struct expression *value = expr->assign.value;
-	assert(object->type == EXPR_ACCESS); // Invariant
 
-	// TODO: When this grows to support e.g. indexing expressions, we need
-	// to ensure that the side-effects of the lvalue occur before the
-	// side-effects of the rvalue.
-	const struct scope_object *obj = object->access.object;
-	struct qbe_value src;
-	qval_for_object(ctx, &src, obj);
-	gen_expression(ctx, value, &src);
+	if (expr->assign.indirect) {
+		struct qbe_value dest = {0};
+		gen_temp(ctx, &dest, &qbe_long, "indirect.%d"); // XXX: ARCH
+		gen_expression(ctx, object, &dest);
+		// TODO: We might want a helper to dereference a qval
+		dest.indirect = true;
+		dest.type = qtype_for_type(ctx, value->result, false);
+		gen_expression(ctx, value, &dest);
+	} else {
+		assert(object->type == EXPR_ACCESS); // Invariant
+		// TODO: When this grows to support e.g. indexing expressions,
+		// we need to ensure that the side-effects of the lvalue occur
+		// before the side-effects of the rvalue.
+		const struct scope_object *obj = object->access.object;
+		struct qbe_value src;
+		qval_for_object(ctx, &src, obj);
+		gen_expression(ctx, value, &src);
+	}
 }
 
 static void